Cita de: 0xDani en 13 Agosto 2013, 13:53 PMYo también voto por poner los atributos como privados, es más lo iba a publicar ahora. En cuanto a lo de C++11 me parece una buena idea, así practicamos. Solo tengo el header de momento pero bueno, las funciones get ya están implementadas:
Sí, en principio no tengo problema en colaborar, tengo tiempo.
En el código que habéis puesto sugiero que se establezcan los atributos de las clases como privados, y métodos getters y setters.
Qué opináis de usar C++ 11?
Código (cpp) [Seleccionar]
#ifndef UNITY_H
#define UNITY_H
#include <string>
class Unity
{
public:
Unity();
void setID (std::string newID);
void setGeneralType (std::string newType);
void setName (std::string newName);
void setNumberOfSoldiers (int newNumberOfSoldiers);
void setInjuredSoldiers (int newInjuredSoldiers);
void setMotivation (float newMotivation);
void setPhysicalState (float newPhysicalState);
void setFavourableWeather (std::string newFavourableWeather);
void setHarmfulWeather (std::string newHarmfulWeather);
void setFavourableTerrain (std::string newFavourableTerrain);
void setHarmfulTerrain (std::string newHarmfulTerrain);
void setMeleeAttack (float newMeleeAttack);
void setMeleeDefense (float newMeleeDefense);
void setLongDistanceAttack (float newLongDistanceAttack);
void setLongDistanceDefense (float newLongDistanceDefense);
void setDiscipline (float newDiscipline);
void setSpeed (float newSpeed);
void setGeneralTypeFavourable (std::string newGeneralTypeFavourable);
void setGeneralTypeHarmful (std::string newGeneralTypeHarmful);
void setConcreteTypeFavourable (std::string newConcreteTypeFavourable);
void setConcreteTypeHarmful (std::string newConcreteTypeHarmful);
void setNutrition (float newNutrition);
void setResistence (float newResistence);
std::string getID() const{return id;}
std::string getGeneralType() const{return generalType;}
std::string getName() const{return name;}
int getNumberOfSoldiers() const{return numberOfSoldiers;}
int getInjuredSoldiers() const{return numberOfInjuredSoldiers;}
float getMotivation() const{return motivation;}
float getPhysicalState() const{return physicalState;}
std::string getFavourableWeather() const{return favourableWeather;}
std::string getHarmfulWeather() const{return harmfulWeather;}
std::string getFavourableTerrain() const{return favourableTerrain;}
std::string getHarmfulTerrain() const{return harmfulTerrain;}
float getMeleeAttack() const{return meleeAttack;}
float getMeleeDefense() const{return meleeDefense;}
float getLongDistanceAttack() const{return longDistanceAttack;}
float getLongDistanceDefense() const{return longDistanceDefense;}
float getDiscipline() const{return discipline;}
float getSpeed() const{return speed;}
std::string getGeneralTypeFavourable() const{return generalTypeFavourable;}
std::string getGeneralTypeHarmful() const{return generalTypeHarmful;}
std::string getConcreteTypeFavourable() const{return concreteTypeFavourable;}
std::string getConcreteTypeHarmful() const{return concreteTypeHarmful;}
float getNutrition() const{return nutrition;}
float getResistence() const{return resistence;}
virtual ~Unity();
private:
std::string id;
std::string generalType;
std::string name;
int numberOfSoldiers;
int numberOfInjuredSoldiers;
float motivation;
float physicalState;
std::string favourableWeather;
std::string harmfulWeather;
std::string favourableTerrain;
std::string harmfulTerrain;
float meleeAttack;
float meleeDefense;
float longDistanceAttack;
float longDistanceDefense;
float discipline;
float speed;
std::string generalTypeFavourable;
std::string generalTypeHarmful;
std::string concreteTypeFavourable;
std::string concreteTypeHarmful;
float nutrition;
float resistence;
};
#endif // UNITY_H